mistercrunch commented on a change in pull request #5524: A tagging system for dashboards, charts and queries URL: https://github.com/apache/incubator-superset/pull/5524#discussion_r207049390
########## File path: superset/models/tags.py ########## @@ -0,0 +1,233 @@ +# -*- coding: utf-8 -*- +# pylint: disable=no-init +from __future__ import absolute_import +from __future__ import division +from __future__ import print_function +from __future__ import unicode_literals + +import enum + +from flask_appbuilder import Model +from sqlalchemy import Column, Enum, ForeignKey, Integer, String +from sqlalchemy.orm import relationship, sessionmaker +from sqlalchemy.orm.exc import NoResultFound + +from superset.models.helpers import AuditMixinNullable + + +Session = sessionmaker(autoflush=False) + + +class TagTypes(enum.Enum): Review comment: I though enums were a py3.4 thing but they appear to have been backported to 2.7, maybe 2.7.6? I'm starting to think we should deprecate our supporte for <py3.6 and embrace all the new great stuff. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
