mistercrunch commented on a change in pull request #5524: A tagging system for
dashboards, charts and queries
URL:
https://github.com/apache/incubator-superset/pull/5524#discussion_r207069055
##########
File path: superset/assets/src/welcome/Tags.jsx
##########
@@ -0,0 +1,151 @@
+/* eslint no-unused-vars: 0 */
+import React from 'react';
+import ReactDOM from 'react-dom';
+import PropTypes from 'prop-types';
+import moment from 'moment';
+import { Table, Tr, Td, Thead, Th, unsafe } from 'reactable';
+import 'whatwg-fetch';
+
+import Loading from '../components/Loading';
+import '../../stylesheets/reactable-pagination.css';
+import { t } from '../locales';
+
+const $ = window.$ = require('jquery');
+
+const propTypes = {
+ search: PropTypes.string,
+};
+
+export function fetchTags(objectType, objectId, includeTypes, callback) {
Review comment:
Thinking about where these utility functions should live. I'm thinking we
may want a `src/tags` folder to store all that is tags-related. I didn't like
to see an app (explore) depending on another app (welcome). This seems to be
pointing towards refactoring tags into it's own folder.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
