mistercrunch commented on a change in pull request #5524: A tagging system for
dashboards, charts and queries
URL:
https://github.com/apache/incubator-superset/pull/5524#discussion_r207656790
##########
File path: superset/assets/src/dashboard/components/Header.jsx
##########
@@ -6,12 +6,21 @@ import HeaderActionsDropdown from './HeaderActionsDropdown';
import EditableTitle from '../../components/EditableTitle';
import Button from '../../components/Button';
import FaveStar from '../../components/FaveStar';
+import ObjectTags from '../../components/ObjectTags';
import UndoRedoKeylisteners from './UndoRedoKeylisteners';
+import {
+ addTag,
+ deleteTag,
+ fetchSuggestions,
+ fetchTags,
+} from '../../welcome/Tags';
import { chartPropShape } from '../util/propShapes';
import { t } from '../../locales';
import { UNDO_LIMIT, SAVE_TYPE_OVERWRITE } from '../util/constants';
+const CSRF_TOKEN = (document.getElementById('csrf_token') || {}).value;
Review comment:
Gotcha, now I'd rather not having it in module scope for the implications it
has that the browser exist, which could be an issue while importing during unit
tests or for code introspection. Simply importing the file in node might spit
out something about `document` not existing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
