villebro commented on a change in pull request #5294: Scheduled email reports
for Slices / Dashboards
URL:
https://github.com/apache/incubator-superset/pull/5294#discussion_r207731857
##########
File path: setup.py
##########
@@ -96,6 +96,8 @@ def get_git_sha():
'thrift-sasl>=0.2.1',
'unicodecsv',
'unidecode>=0.04.21',
+ 'croniter==0.3.24',
+ 'selenium==3.12.0',
],
Review comment:
@mahendra IMO fixing deprecations and possible future breakages tends to be
fairly straight forward, and shouldn't be a big issue. So from a
maintainability perspective leaving them unpegged would probably be better, as
it would allow for features/fixes to flow in automatically.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
