villebro commented on a change in pull request #5294: Scheduled email reports
for Slices / Dashboards
URL:
https://github.com/apache/incubator-superset/pull/5294#discussion_r207897889
##########
File path: setup.py
##########
@@ -96,6 +96,8 @@ def get_git_sha():
'thrift-sasl>=0.2.1',
'unicodecsv',
'unidecode>=0.04.21',
+ 'croniter==0.3.24',
+ 'selenium==3.12.0',
],
Review comment:
@mahendra I understand, perhaps @betodealmeida or one of the official
maintainers can weigh in? As there doesn't seem to be any known incompatibility
issues with `croniter>0.3.24` and `selenium>3.12.0`, and this is a new feature,
I think any users testing it will be aware that they should expect a bug or two
as this is rolled out. If incompatibility issues do arise, I feel they are best
taken care of by making changes to the Superset code to accomodate API changes
etc. Only in the case of a serious divergence in features or known bugs should
we pin to an old version in `master`. Perhaps even fixing the dependency
versions in `setup.py` of `0.27` might be an option.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
