john-bodley closed pull request #5433: [bar-chart] Fix issue with non-string
names in series title
URL: https://github.com/apache/incubator-superset/pull/5433
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/superset/viz.py b/superset/viz.py
index e50ee1b77a..c060e19550 100644
--- a/superset/viz.py
+++ b/superset/viz.py
@@ -1527,11 +1527,9 @@ def get_data(self, df):
continue
if isinstance(name, string_types):
series_title = name
- elif len(metrics) > 1:
- series_title = ', '.join(name)
else:
- l = [text_type(s) for s in name[1:]] # noqa: E741
- series_title = ', '.join(l)
+ offset = 0 if len(metrics) > 1 else 1
+ series_title = ', '.join([text_type(s) for s in name[offset:]])
values = []
for i, v in ys.items():
x = i
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
