mistercrunch opened a new pull request #5636: [explore] fix the 'altered' tag false positive URL: https://github.com/apache/incubator-superset/pull/5636 The altered tag shows up in many cases where it shouldn't. First it's common for the loaded examples to have extra keys in their form_data, they were designed that way knowing extra keys get removed along the way (only the form_data relevant to a particular viz type makes it through). Though then there was a few lines added to allow for `url_params` through, but brought back the kitchen sink as it merged all other bad keys. This also creates problems around metrics and such as switching viz types. As an alternative approach, I added `url_params` as a HiddenControl so that it can flow using the common form_data flow. Note that: * `url_params` will get saved with the chart metadata, but overriden on explore. It appears that the logic that bakes the `url_params` applies only to explore, not dashboards, meaning unless we call `merge_request_params` on the dashobard endpoint, the `url_params` would show as saved on the chart. * I cleaned up some dup logic in index.js * I can't test that very much as I don't fully understand the use case, it appears url_params never worked with dashboards for instance @michellethomas @graceguo-supercat let me know what you think
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
