williaster commented on a change in pull request #5771: [dashboard] Add alert
when user deleting root level tab
URL:
https://github.com/apache/incubator-superset/pull/5771#discussion_r213801017
##########
File path: superset/assets/src/dashboard/components/IconButton.jsx
##########
@@ -2,14 +2,15 @@ import React from 'react';
import PropTypes from 'prop-types';
const propTypes = {
- onClick: PropTypes.func.isRequired,
+ onClick: PropTypes.func,
className: PropTypes.string,
label: PropTypes.string,
};
const defaultProps = {
className: null,
label: null,
+ onClick: () => true,
Review comment:
hmm this is a little strange, but I guess is okay. Is this preferred so you
don't have to set styles on a simple `<div className="fa fa-trash" />`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
