williaster commented on a change in pull request #5771: [dashboard] Add alert
when user deleting root level tab
URL:
https://github.com/apache/incubator-superset/pull/5771#discussion_r213801201
##########
File path: superset/assets/src/dashboard/components/menu/WithPopoverMenu.jsx
##########
@@ -36,19 +37,19 @@ class WithPopoverMenu extends React.PureComponent {
componentWillReceiveProps(nextProps) {
if (nextProps.editMode && nextProps.isFocused && !this.state.isFocused) {
- document.addEventListener('click', this.handleClick, true);
Review comment:
yeah still can't remember why I added these 🤷♀️
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
