mistercrunch commented on a change in pull request #5902: [refactor] Remove
dependency on personal fork of supercluster from mapbox visualizations
URL:
https://github.com/apache/incubator-superset/pull/5902#discussion_r218211316
##########
File path: superset/assets/src/visualizations/MapBox/MapBox.jsx
##########
@@ -170,18 +151,41 @@ function mapbox(slice, payload, setControlValue) {
return;
}
- const clusterer = supercluster({
+ const opts = {
radius: clusteringRadius,
maxZoom: DEFAULT_MAX_ZOOM,
- metricKey: 'metric',
- metricReducer: createReducer(aggregatorName, customMetric),
- });
+ };
+ if (customMetric) {
+ opts.initial = () => ({
+ sum: 0,
+ squaredSum: 0,
+ min: Infinity,
+ max: -Infinity,
+ });
+ opts.map = prop => ({
+ sum: prop.metric,
+ squaredSum: Math.pow(prop.metric, 2),
+ min: prop.metric,
+ max: prop.metric,
+ });
+ opts.reduce = (accu, prop) => {
+ // Temporarily disable param-reassignment linting to work with
supercluster's api
+ /* eslint-disable no-param-reassign */
Review comment:
[non actionable] interesting related conversation:
https://github.com/eslint/eslint/issues/8581
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
