mistercrunch commented on a change in pull request #5902: [refactor] Remove
dependency on personal fork of supercluster from mapbox visualizations
URL:
https://github.com/apache/incubator-superset/pull/5902#discussion_r218211090
##########
File path: superset/viz.py
##########
@@ -1960,7 +1960,7 @@ def get_data(self, df):
return None
fd = self.form_data
label_col = fd.get('mapbox_label')
- custom_metric = label_col and len(label_col) >= 1
+ custom_metric = bool(label_col) and len(label_col) >= 1
Review comment:
[optional] we typically don't cast to bool in python, (direct checks on
whether a value is truthy are common), but I can see where it's coming from.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
