conglei commented on a change in pull request #5893: [SIP-6] Add reactify
function and convert world map to new directory structure.
URL:
https://github.com/apache/incubator-superset/pull/5893#discussion_r218254433
##########
File path: superset/assets/src/visualizations/index.js
##########
@@ -108,7 +108,7 @@ const vizMap = {
[VIZ_TYPES.word_cloud]: () =>
loadVis(import(/* webpackChunkName: "word_cloud" */
'./wordcloud/WordCloud.js')),
[VIZ_TYPES.world_map]: () =>
- loadVis(import(/* webpackChunkName: "world_map" */ './world_map.js')),
+ loadVis(import(/* webpackChunkName: "world_map" */
'./WorldMap/adaptor.jsx')),
Review comment:
Can we add `index.js` for each file and export `adaptor` there as default.
Potentially we also want to just import the chart itself in the plugin system
world.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
