conglei commented on a change in pull request #5893: [SIP-6] Add reactify function and convert world map to new directory structure. URL: https://github.com/apache/incubator-superset/pull/5893#discussion_r218253541
########## File path: superset/assets/src/visualizations/WorldMap/adaptor.jsx ########## @@ -0,0 +1,5 @@ +import createAdaptor from '../../utils/createAdaptor'; Review comment: I'm thinking how to make each visualization as self contained (independent with superset code) as possible. But it seems now it is hard to do so, otherwise there will be duplicated codes like this for each visualizations type. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
