mistercrunch commented on issue #5918: [bugfix] Fixing linting error in macro_tests URL: https://github.com/apache/incubator-superset/pull/5918#issuecomment-422566803 Wait does that mean that every single PR out there needs to be rebased every time another one is merged? If that's the case it seems like a really bad idea. I'm not even sure Travis-CI could take the extra load. It's pretty rare that stuff like this collide. [working build + working build ~= working build] 95%+ of the time. Picture if I merge this and all other PRs have to be rebased, and we have to wait for CI on all those other builds. This is a lot more time than fixing the very occasional master.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
