mistercrunch commented on issue #5918: [bugfix] Fixing linting error in macro_tests URL: https://github.com/apache/incubator-superset/pull/5918#issuecomment-422570752 Here's another idea to mitigate this. The problem here is "a broken build", which really in most cases the broken build is really just a lint issue related to a bad merge. Maybe the solution is that we should not break the build on lint errors, and instead warn on the PR, and have a policy (either hard or softly enforced) to not merge PRs with lint. This way, when lint shows up as a byproduct or a merge, it wouldn't break the build, it would just generate a tiny bit of lint for anyone who rebases while in this state, and those who do would fix that one-liner. That would prevent the false-negative "broken build".
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
