xtinec commented on a change in pull request #5934: Ensure npm run build is in
production mode
URL:
https://github.com/apache/incubator-superset/pull/5934#discussion_r219338895
##########
File path: superset/assets/package.json
##########
@@ -15,7 +15,7 @@
"dev": "webpack --mode=development --colors --progress --debug --watch",
"dev-server": "webpack-dev-server --mode=development --progress",
"prod": "node --max_old_space_size=4096 webpack --mode=production --colors
--progress",
Review comment:
I found an old PR from 2016 that reduced the size to what it is today.
https://github.com/apache/incubator-superset/pull/1679
Seems like there is no harm deleting it as the reasoning is weakened today
with RAMs getting bigger. 😄
We should probably update this bit in `CONTRIBUTING.md` before deleting
`prod` and also make a note in `UPDATING.md` in case anyone has `npm/yarn run
prod` in their build pipeline.
```
# Compile the Javascript and CSS in production/optimized mode for official
releases
npm run prod
```
Thoughts? @mistercrunch @williaster @kristw
I'm also cool with this PR shipping as-is. Going to go ahead and approve
now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
