kristw commented on a change in pull request #5974: [cypress] add SQL lab tests
URL:
https://github.com/apache/incubator-superset/pull/5974#discussion_r220648873
##########
File path: superset/assets/cypress/selectors/index.js
##########
@@ -0,0 +1 @@
+export const selectResultsTab = () => cy.get('.SouthPane
.ReactVirtualized__Table');
Review comment:
I agree with not writing selector string multiple times. More thinking about
where to put the function. My main concern is avoiding a setup that leads to
one exploding file that contains selectors from every part of Superset. From
the name of the file now it invites people to add selector from all other pages
here. Other options would be
- Rename this to `sqlLab.js` to scope it a bit.
- Put the function in test file itself.
I am more comfortable with either option above.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
