kristw commented on a change in pull request #5974: [cypress] add SQL lab tests
URL:
https://github.com/apache/incubator-superset/pull/5974#discussion_r223827164
##########
File path: superset/assets/cypress/integration/sqllab/sourcePanel.js
##########
@@ -0,0 +1,60 @@
+import { selectResultsTab } from './sqllab.helper';
+
+export default () => {
+ describe('SqlLab datasource panel', () => {
+ beforeEach(() => {
+ cy.login();
+ cy.server();
+ cy.visit('/superset/sqllab');
+ });
+
+ it('renders dropdowns to select database, schema, and table', () => {
Review comment:
for a small test like this, perhaps merge with the following test to save
runtime.
Can also use `should('have.length')` instead of `.then( expect )`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
