williaster edited a comment on issue #6079: [refactor] Migrate from Mocha+Chai to Jest URL: https://github.com/apache/incubator-superset/pull/6079#issuecomment-429465880 @kristw I agree we should remove `babel-istanbul` but do we need `babel-plugin-istanbul`? `jest` computes coverage on its own, so we could change the coverage script to simply be `"cover": "[jest --coverage](https://jestjs.io/docs/en/cli.html#coverage)"` note this is compatible with our current setup for `coveralls`, [I mirrored this in `superset-ui`](https://github.com/apache-superset/superset-ui/blob/master/.travis.yml#L27) which uses `jest`
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
