mistercrunch commented on a change in pull request #6220: [SIP-5] Open a new
/api/v1/query endpoint that takes query_obj
URL:
https://github.com/apache/incubator-superset/pull/6220#discussion_r229534438
##########
File path: superset/utils/core.py
##########
@@ -213,6 +213,29 @@ def dttm_from_timtuple(d):
d.tm_year, d.tm_mon, d.tm_mday, d.tm_hour, d.tm_min, d.tm_sec)
+def decode_iso_dttm(o):
Review comment:
Mmmh, can we just decode the ISOs values under the keys we know may be ISOs?
If we want to cache to be determined from the query_obj, we'd need the relative
time expressions here too, haven't given too much thought to this, but we
should make a conscious decision as to whether query_obj would need to know
about relative time exprs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
