mistercrunch commented on a change in pull request #6220: [SIP-5] Open a new
/api/v1/query endpoint that takes query_obj
URL:
https://github.com/apache/incubator-superset/pull/6220#discussion_r229835010
##########
File path: superset/utils/core.py
##########
@@ -213,6 +213,29 @@ def dttm_from_timtuple(d):
d.tm_year, d.tm_mon, d.tm_mday, d.tm_hour, d.tm_min, d.tm_sec)
+def decode_iso_dttm(o):
Review comment:
some ideas:
```python
class QueryObject:
def init({pretty much all args in the connectors}, from_dttm_expr,
to_dttm_expr):
"""hey we could use py3 type annotations here!"""
pass
@property
def cache_key():
"""Returns the cache key"""
def get_df(allow_cache=True, cache_timeout=None):
"""Runs the query and returns a pandas dataframe"""
@property
def is_cached():
pass
def _try_get_df_from_cache():
pass
{many other methods and generally logic that belongs here more than in
BaseViz}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
