mistercrunch closed pull request #6228: [sql lab] improve placeholder strings
for query search form
URL: https://github.com/apache/incubator-superset/pull/6228
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/superset/assets/src/SqlLab/components/QuerySearch.jsx
b/superset/assets/src/SqlLab/components/QuerySearch.jsx
index 9e920295a0..04cb52ae8d 100644
--- a/superset/assets/src/SqlLab/components/QuerySearch.jsx
+++ b/superset/assets/src/SqlLab/components/QuerySearch.jsx
@@ -183,6 +183,7 @@ class QuerySearch extends React.PureComponent {
mutator={this.userMutator}
value={this.state.userId}
onChange={this.changeUser}
+ placeholder={t('Filter by user')}
/>
</div>
<div className="col-sm-2">
@@ -191,6 +192,7 @@ class QuerySearch extends React.PureComponent {
dataEndpoint="/databaseasync/api/read?_flt_0_expose_in_sqllab=1"
value={this.state.databaseId}
mutator={this.dbMutator}
+ placeholder={t('Filter by database')}
/>
</div>
<div className="col-sm-4">
@@ -199,7 +201,7 @@ class QuerySearch extends React.PureComponent {
onChange={this.changeSearch}
onKeyDown={this.onKeyDown}
className="form-control input-sm"
- placeholder={t('Search Results')}
+ placeholder={t('Query search string')}
/>
</div>
<div className="col-sm-4 search-date-filter-container">
@@ -226,7 +228,7 @@ class QuerySearch extends React.PureComponent {
<Select
name="select-status"
- placeholder={t('[Query Status]')}
+ placeholder={t('Filter by status')}
options={Object.keys(STATUS_OPTIONS).map(s => ({ value: s,
label: s }))}
value={this.state.status}
isLoading={false}
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
