mistercrunch closed pull request #6231: [bugfix] cannot add options to FilterBox
URL: https://github.com/apache/incubator-superset/pull/6231
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/superset/assets/src/visualizations/FilterBox/FilterBox.jsx
b/superset/assets/src/visualizations/FilterBox/FilterBox.jsx
index 907e802025..8b798bbcc8 100644
--- a/superset/assets/src/visualizations/FilterBox/FilterBox.jsx
+++ b/superset/assets/src/visualizations/FilterBox/FilterBox.jsx
@@ -178,8 +178,7 @@ class FilterBox extends React.Component {
// Add created options to filtersChoices, even though it doesn't exist,
// or these options will exist in query sql but invisible to end user.
Object.keys(selectedValues)
- .filter(key => !selectedValues.hasOwnProperty(key)
- || !(key in filtersChoices))
+ .filter(key => selectedValues.hasOwnProperty(key) && (key in
filtersChoices))
.forEach((key) => {
const choices = filtersChoices[key] || [];
const choiceIds = new Set(choices.map(f => f.id));
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
