mistercrunch commented on a change in pull request #6220: [SIP-5] Open a new
/api/v1/query endpoint that takes query_obj
URL:
https://github.com/apache/incubator-superset/pull/6220#discussion_r229838118
##########
File path: superset/models/core.py
##########
@@ -85,6 +85,37 @@ def copy_dashboard(mapper, connection, target):
session.commit()
+def query_obj_backfill(form_data, datasource_id=None, datasource_type=None):
Review comment:
There was a time where `form_data` did not include datasource_id &
datasource_type, but now it always does in the shape of `fd.get('datasource')
== '231__sqla'` or something like that.
Meaning `datasource_id` and `datasource_type` are redundant in this method's
signature and we could do without.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
