williaster commented on a change in pull request #6257: Add sql lab 
localStorage config
URL: 
https://github.com/apache/incubator-superset/pull/6257#discussion_r230204410
 
 

 ##########
 File path: superset/assets/src/SqlLab/reducers.js
 ##########
 @@ -278,7 +278,12 @@ export const sqlLabReducer = function (state = {}, 
action) {
   return state;
 };
 
+export const commonReducer = function (state = {}) {
 
 Review comment:
   can you put this in its own file so we define the reducer for one part of 
the state tree per file?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to