williaster commented on a change in pull request #6257: Add sql lab
localStorage config
URL:
https://github.com/apache/incubator-superset/pull/6257#discussion_r230223841
##########
File path: superset/assets/src/SqlLab/reducers.js
##########
@@ -278,7 +278,12 @@ export const sqlLabReducer = function (state = {},
action) {
return state;
};
+export const commonReducer = function (state = {}) {
Review comment:
I'd say yes, the number of files in Superset that have thousands of lines is
crazy makes them all harder to read. it's really trivial to add a new file imo.
up to you tho.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
