mistercrunch commented on a change in pull request #6220: [SIP-5] Open a new
/api/v1/query endpoint that takes query_obj
URL:
https://github.com/apache/incubator-superset/pull/6220#discussion_r230999108
##########
File path: superset/utils/core.py
##########
@@ -940,15 +940,20 @@ def get_since_until(form_data):
since = today
until = today + relativedelta(**{grain: int(num)})
else:
- since = form_data.get('since', '')
+ since = since or ''
if since:
since = add_ago_to_since(since)
since = parse_human_datetime(since)
- until = parse_human_datetime(form_data.get('until', 'now'))
+ until = parse_human_datetime(until or 'now')
return since, until
+def check_from_to_dttm(from_dttm, to_dttm):
+ if from_dttm and to_dttm and from_dttm > to_dttm:
+ raise Exception(_('From date cannot be larger than to date'))
Review comment:
NIT: `ValueError` is a bit better than `Exception`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
