mistercrunch commented on a change in pull request #6220: [SIP-5] Open a new
/api/v1/query endpoint that takes query_obj
URL:
https://github.com/apache/incubator-superset/pull/6220#discussion_r230999934
##########
File path: superset/security.py
##########
@@ -428,3 +429,10 @@ def set_perm(self, mapper, connection, target): # noqa
view_menu_id=view_menu.id,
),
)
+
+ def check_datasource_permission(self, datasource, user=None):
Review comment:
👍 nice refactor, tiny NIT where the name `assert_datasource_permission `
could be a bit more clear about the fact that it's a "raise if that's not the
case". `check_%` could sound more like it's returning a boolean.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
