michael-s-molina opened a new pull request #14714:
URL: https://github.com/apache/superset/pull/14714


   ### SUMMARY
   Improves the native filters UI/UX - iteration 1.
   
   - Sets a fixed `height` for the modal
   - Splits the configuration and scoping into different tabs
   - Inverts the order of the buttons of the confirmation message
   - Removes the x icon of the confirmation message
   - Fixes the tests to account for the async nature of the screen
   
   PS: A future PR will handle the case of automatically selecting a 
tab/collapse when an error occurs.
   
   @villebro @rusackas @junlincc 
   
   This work is part of the [Native dashboard filter 
project](https://github.com/apache/superset/projects/12)
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
https://user-images.githubusercontent.com/70410625/118834003-49585e80-b898-11eb-855a-34a301d46c71.mov
   
   
https://user-images.githubusercontent.com/70410625/118834020-4c534f00-b898-11eb-900f-aeb15c8dafba.mov
   
   ### TEST PLAN
   1 - Execute all tests
   2 - All tests should pass
   
   ### ADDITIONAL INFORMATION
   - [ ] Has associated issue:
   - [x] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to