geido commented on a change in pull request #14463:
URL: https://github.com/apache/superset/pull/14463#discussion_r635963140
##########
File path: superset-frontend/src/SqlLab/components/SqlEditor.jsx
##########
@@ -638,7 +638,9 @@ class SqlEditor extends React.PureComponent {
this.props.defaultQueryLimit,
)}
</span>
- <Icon name="triangle-down" />
+ <Icons.TriangleDown
+ iconColor={supersetTheme.colors.grayscale.base}
Review comment:
So I checked this @pkdotson @rusackas. In reality, the icon is correctly
inheriting the color of the container, which is black. But the icon here is
intended to be #666 reason why Phillip specified. With the previous icon
implementation, that wasn't necessary for the simple fact that #666 was the
default color of the icons. We might make it the default also for the new icon
implementation if that can avoid specifying it all the time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
