geido commented on a change in pull request #14463:
URL: https://github.com/apache/superset/pull/14463#discussion_r627542584
##########
File path: superset-frontend/src/SqlLab/components/SqlEditor.jsx
##########
@@ -638,7 +638,9 @@ class SqlEditor extends React.PureComponent {
this.props.defaultQueryLimit,
)}
</span>
- <Icon name="triangle-down" />
+ <Icons.TriangleDown
+ iconColor={supersetTheme.colors.grayscale.base}
Review comment:
Hi @pkdotson the icons should inherit the color of the container? Is it
here a particular issue for which you need to specify the color while with the
previous implementation it wasn't necessary?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
