villebro commented on a change in pull request #14693:
URL: https://github.com/apache/superset/pull/14693#discussion_r636056270
##########
File path: superset-frontend/src/dashboard/actions/nativeFilters.ts
##########
@@ -116,7 +116,7 @@ type BootstrapData = {
};
};
-export interface SetBooststapData {
+export interface SetBootstrapData {
Review comment:
This gave me fond memories of C++ https://www.boost.org/
##########
File path: superset-frontend/src/filters/components/common.ts
##########
@@ -21,8 +21,8 @@ import { Select } from 'src/common/components';
import { PluginFilterStylesProps } from './types';
export const Styles = styled.div<PluginFilterStylesProps>`
- height: ${({ height }) => height};
- width: ${({ width }) => width};
+ height: ${({ height }) => height}px;
+ width: ${({ width }) => width}px;
Review comment:
oh one of these again 👍
##########
File path: superset-frontend/src/filters/components/GroupBy/types.ts
##########
@@ -40,6 +40,8 @@ export type PluginFilterGroupByProps =
PluginFilterStylesProps & {
behaviors: Behavior[];
data: DataRecord[];
setDataMask: SetDataMaskHook;
+ setFocusedFilter: () => void;
+ unsetFocusedFilter: () => void;
Review comment:
Simplification idea: we could move the `setDataMask`, `setFocusedFilter`
and `unsetFocusedFilter` into a shared interface/type `PluginFilterHooks` in
`filters/components/types.ts` and then just `&` them into
`PluginFilterGroupByProps` and the others.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
