junlincc edited a comment on pull request #14693: URL: https://github.com/apache/superset/pull/14693#issuecomment-845434122
@graceguo-supercat for current iteration - we will grey out filters that are not scoped to tabs from the filter bar, as just a visual suggestion that the specific filter won’t apply in the current scope(instead of disabling it). This should reach feature parity with filter box highlighting behavior For range filter, blue circle will be greyed out; for time range, color darker grey on hovering <img width="234" alt="Screen Shot 2021-05-20 at 9 57 41 AM" src="https://user-images.githubusercontent.com/67837651/119040842-c2c08180-b96a-11eb-86b8-8a67c1695906.png";> Above change will be made in separate PRs We can discuss next iteration, including grouping or foldering filters to tabs(but not now). 🙏 @kgabryje please go ahead and merge your PR, I will take a deeper look once multiple native filter PRs are all merged. cc @michael-s-molina -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
![https://user-images.githubusercontent.com/67837651/119040842-c2c08180-b96a-11eb-86b8-8a67c1695906.png"](https://user-images.githubusercontent.com/67837651/119040842-c2c08180-b96a-11eb-86b8-8a67c1695906.png"){kind=link}