AAfghahi opened a new pull request #14741: URL: https://github.com/apache/superset/pull/14741
### SUMMARY This is addressing the fix found in: https://github.com/apache/superset/pull/14719 This adds testing to the ResultSet spec file that checks to make sure that either queryLimit or query.results.limit is present. Without either of these ResultSet throws an error which crashes SqlLab. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF N/A ### TEST PLAN This adds two new tests to ResultSet, checking to make sure that it renders correctly if either of these are present. I also added limit to the query fixture. ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
