geido commented on a change in pull request #14741:
URL: https://github.com/apache/superset/pull/14741#discussion_r637938402
##########
File path: superset-frontend/spec/javascripts/sqllab/ResultSet_spec.jsx
##########
@@ -38,49 +39,48 @@ import {
stoppedQuery,
initialState,
user,
+ queryWithNoQueryLimit,
} from './fixtures';
const mockStore = configureStore([thunk]);
const store = mockStore(initialState);
-
-describe('ResultSet', () => {
- const clearQuerySpy = sinon.spy();
- const fetchQuerySpy = sinon.spy();
- const reRunQuerySpy = sinon.spy();
- const mockedProps = {
- actions: {
- clearQueryResults: clearQuerySpy,
- fetchQueryResults: fetchQuerySpy,
- reRunQuery: reRunQuerySpy,
- },
- cache: true,
- query: queries[0],
- height: 140,
- database: { allows_virtual_table_explore: true },
- user,
- defaultQueryLimit: 1000,
- };
- const stoppedQueryProps = { ...mockedProps, query: stoppedQuery };
- const runningQueryProps = { ...mockedProps, query: runningQuery };
- const cachedQueryProps = { ...mockedProps, query: cachedQuery };
- const failedQueryWithErrorMessageProps = {
- ...mockedProps,
- query: failedQueryWithErrorMessage,
- };
- const failedQueryWithErrorsProps = {
- ...mockedProps,
- query: failedQueryWithErrors,
- };
- const newProps = {
- query: {
- cached: false,
- resultsKey: 'new key',
- results: {
- data: [{ a: 1 }],
- },
+const clearQuerySpy = sinon.spy();
+const fetchQuerySpy = sinon.spy();
+const reRunQuerySpy = sinon.spy();
+const mockedProps = {
+ actions: {
+ clearQueryResults: clearQuerySpy,
+ fetchQueryResults: fetchQuerySpy,
+ reRunQuery: reRunQuerySpy,
+ },
+ cache: true,
+ query: queries[0],
+ height: 140,
+ database: { allows_virtual_table_explore: true },
+ user,
+ defaultQueryLimit: 1000,
+};
+const stoppedQueryProps = { ...mockedProps, query: stoppedQuery };
+const runningQueryProps = { ...mockedProps, query: runningQuery };
+const cachedQueryProps = { ...mockedProps, query: cachedQuery };
+const failedQueryWithErrorMessageProps = {
+ ...mockedProps,
+ query: failedQueryWithErrorMessage,
+};
+const failedQueryWithErrorsProps = {
+ ...mockedProps,
+ query: failedQueryWithErrors,
+};
+const newProps = {
+ query: {
+ cached: false,
+ resultsKey: 'new key',
+ results: {
+ data: [{ a: 1 }],
},
- };
-
+ },
+};
+describe('ResultSet', () => {
Review comment:
Let's go straight to the test without nesting in describe. That's the
approach we have been trying to use lately
##########
File path: superset-frontend/spec/javascripts/sqllab/ResultSet_spec.jsx
##########
@@ -182,3 +182,16 @@ describe('ResultSet', () => {
});
});
});
+
+describe('RTL ResultSet tests', () => {
Review comment:
Same as my other comment concerning the usage of describe
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
