corbinrobb opened a new pull request #14830:
URL: https://github.com/apache/superset/pull/14830


   ### SUMMARY
   Update the TableElement class component to be a functional component using 
hooks.
   
   Modified the tests slightly where needed to check the changes to DOM from 
updating the state instead of checking the component state itself. Was 
necessary because functional components using hooks don't have an accessible 
state like class components.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   The component should look and function the same
   
   ### TESTING INSTRUCTIONS
   To run the tests for TableElement navigate to superset-frontend and run `npm 
run test -- spec/javascripts/sqllab/TableElement_spec.jsx`
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to