corbinrobb edited a comment on pull request #14830: URL: https://github.com/apache/superset/pull/14830#issuecomment-849812342
*** Figured it would make sense to grab a ticket that is also making changes in this component. Please let me know if this should be in another PR or if there's a better way to handle it. Thanks! *** ## [sql lab]'copy' and 'collapse/expand' icons do not have tooltip in the table review panel ### SUMMARY Fixed an issue where the tooltip for the copy/paste was not showing up and added a tooltip to the collapse/expand icon on the table element. Updated tests where necessary. ### BEFORE  ### AFTER  ### TESTING INSTRUCTIONS To run the tests for TableElement navigate to superset-frontend and run `npm run test -- spec/javascripts/sqllab/TableElement_spec.jsx` ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
