eschutho opened a new pull request #14832: URL: https://github.com/apache/superset/pull/14832
### SUMMARY This PR uses the validation api and the new LabeledErrorBoundInput component to validate a person's db connection as they are filling out the form. The validation happens on blur. We plan to add some client side validation on types such as checking that hostnames don't have spaces and port is a number, etc. That will come in a separate PR. For now, all of this work is not visible to the user. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF https://user-images.githubusercontent.com/5186919/119589260-4c1aee00-bd87-11eb-8914-129f58e9ed8d.mov I left the network requests tab open so that we can evaluate how many requests are made during this flow, to see if it needs to be optimized. We could evaluate if anything changed on blur if needed. ### TESTING INSTRUCTIONS For now, let's make sure that this code doesn't break anything existing. Try creating a database and editing one. ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
