eschutho commented on a change in pull request #14832:
URL: https://github.com/apache/superset/pull/14832#discussion_r639343568
##########
File path: superset/databases/commands/validate.py
##########
@@ -90,7 +92,7 @@ def run(self) -> None:
# try to connect
sqlalchemy_uri = engine_spec.build_sqlalchemy_uri(
- self._properties["parameters"], # type: ignore
+ self._properties.get("parameters", None), # type: ignore
Review comment:
@betodealmeida I put some guards here against null values. Not sure if
you want to catch them in an earlier validation or not. I also made a similar
note about passing in port as a string that needs to be validated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
