michael-s-molina opened a new pull request #14854: URL: https://github.com/apache/superset/pull/14854
### SUMMARY Improves the native filters UI/UX - iteration 4. - Handle the correct tab selection when validating - Add a required icon and validation to the controllers when their checkbox is checked - The controls with affectsDataMask are disabled unless the default value picker is enabled This work is part of the [Native dashboard filter project](https://github.com/apache/superset/projects/12) The items below will be handled in the next iterations: - Add a scroll bar to the left panel - Fix left panel layout when the scroll is active - Adjust fonts and colors to match the design - Make the tabs stick to the top while scrolling - Remove horizontal scroll when the column select is too wide The iterations below are optional but recommended: - Split the FiltersConfigForm into smaller components to make it easier to read - Unify the select components to use the AntD one. Currently, we have different selects with different themes and interactions. @villebro @rusackas @junlincc ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF https://user-images.githubusercontent.com/70410625/119733570-1db51580-be50-11eb-859e-eed98805bd2a.mp4 https://user-images.githubusercontent.com/70410625/119733621-2dccf500-be50-11eb-9a46-bdcce7056b01.mp4 ### TESTING INSTRUCTIONS 1 - Enable native filters feature flag 2 - Enter in a dashboard 3 - Add a native filter 4 - Check the screen ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [x] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
