villebro commented on a change in pull request #14854:
URL: https://github.com/apache/superset/pull/14854#discussion_r640503076
##########
File path:
superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/FiltersConfigForm.tsx
##########
@@ -606,7 +692,12 @@ export const FiltersConfigForm:
React.FC<FiltersConfigFormProps> = ({
});
forceUpdate();
}}
- label={<StyledLabel>{t('Adhoc filters')}</StyledLabel>}
+ label={
+ <span>
+ <StyledAsterisk>*</StyledAsterisk>
Review comment:
Nit: it would feel more intuitive if this were just `<StyledAsterisk />`
without having to explicitly put in the asterisk as a child (I assume we don't
expect to put in other characters in it).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
