rusackas commented on a change in pull request #14844:
URL: https://github.com/apache/superset/pull/14844#discussion_r640379087
##########
File path: superset-frontend/src/datasource/ChangeDatasourceModal.tsx
##########
@@ -208,6 +211,28 @@ const ChangeDatasourceModal:
FunctionComponent<ChangeDatasourceModalProps> = ({
return data;
};
+ const customGotoPage = (p: number) => {
+ SupersetClient.get({
+ endpoint: `/api/v1/dataset/?q=${rison.encode({
+ order_column: 'changed_on_delta_humanized',
+ order_direction: 'desc',
+ page: p - 1,
+ page_size: 20,
+ })}`,
+ }).then(resources => {
+ setPageIndex(p - 1);
+ setResourceCollection(resources.json.result);
+ });
+ };
+
+ const styleOverride = css`
+ .table-condensed {
+ height: 300px;
Review comment:
Do we need to lock this to 300px tall, or is it possible to let it get
taller, and not need to scroll when the viewport is tall enough?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
