pkdotson commented on pull request #14844: URL: https://github.com/apache/superset/pull/14844#issuecomment-849904922
> Left some comments of varied importance, but there's one thing I noticed while testing. > > The good news is, we can now see each page of the datasets! > > The bad news is, the table header sorting only sorts the particular page of results you're looking at, not the _whole set_ > >  > > For an example approach, the CRUD views work nicely, in that if you are sorting alphabetically, the first items on page one are _all_ the `A`s, and the last item on the last page are all the `Z`s. > > I think it's worth solving this in a followup PR, where clicking the sort header changes the orderBy parameter on the query itself. > > Side note: (cc @junlincc here) the sort on `name` doesn't seem to work at all, really. That's not the fault of this PR, as far as I see. Can you confirm, and if that's the case, file an Issue? Thanks! Yes i'll create a ticket to do a follow up for server sorting to keep the scope of pagination with this pr. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
