simcha90 opened a new pull request #14869: URL: https://github.com/apache/superset/pull/14869
### SUMMARY <!--- Describe the change below, including rationale and design decisions --> This PR: 1. Fixed support for default first value in Select native filter It includes next logic: - if one of control panel items contains `requiredFirst` flag we cancel delay of native filters loading, delay charts loading until this filter will be initialized - we do assumption if `filterState.value === undefined`, it means that filter not initialized - if it has `defaultToFirstValue` option enabled - we save on `filterState.value` undefined value and on filter loading we on the fly put first value 2. Added test for Select native filter ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> https://user-images.githubusercontent.com/56388545/119837538-5b2aa900-bf0b-11eb-9eee-83c90402477d.mov ### TESTING INSTRUCTIONS <!--- Required! What steps can be taken to manually verify the changes? --> ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
