simcha90 commented on a change in pull request #14869:
URL: https://github.com/apache/superset/pull/14869#discussion_r642581280
##########
File path:
superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/FiltersConfigForm.tsx
##########
@@ -599,9 +601,11 @@ const FiltersConfigForm = (
if (hasValue) {
return Promise.resolve();
}
- return Promise.reject(
- new Error(t('Default value is required')),
- );
+ return Promise.resolve();
+ // TODO: Some values does default value empty and
disabled so there is no value
+ // return Promise.reject(
+ // new Error(t('Default value is required')),
+ // );
Review comment:
current logic of defaultToFirstValue, requires to leave default value as
`undefined` so it will fail on this validation, we can put some specific value
here because it can different for different users
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
