zhaoyongjie opened a new pull request #14894: URL: https://github.com/apache/superset/pull/14894
### SUMMARY <!--- Describe the change below, including rationale and design decisions --> Superset now uses `generic_type` to determine the icon that displays the column type. The `generic type` is an abstraction of the database column type, such as: - integer/number/float mapping to `NUMERIC` - varchar/text/string mapping to `STRING` - datetime/timestamp mapping to `TEMPORAL` - boolean/tinyint mapping to `BOOLEAN` But there is one exception for historical reasons: - The user can set a column as a datetime type, even if the column is of another column type. unfortunately this is not done by a SQL cast expression function, just a flag. This PR resolve returns the `TEMPORAL` by determining whether the column contains the is_dttm flag, no matter what type it is. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> #### Before <img width="1445" alt="image" src="https://user-images.githubusercontent.com/2016594/119958530-b5903c00-bfd5-11eb-8f03-2075fbed534c.png";> ### After https://user-images.githubusercontent.com/2016594/119959278-6eef1180-bfd6-11eb-80d9-adf42b1d55e7.mp4 ### TESTING INSTRUCTIONS <!--- Required! What steps can be taken to manually verify the changes? --> ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
![https://user-images.githubusercontent.com/2016594/119958530-b5903c00-bfd5-11eb-8f03-2075fbed534c.png"](https://user-images.githubusercontent.com/2016594/119958530-b5903c00-bfd5-11eb-8f03-2075fbed534c.png"){kind=link}