villebro commented on a change in pull request #14894:
URL: https://github.com/apache/superset/pull/14894#discussion_r641413125
##########
File path: superset/connectors/sqla/models.py
##########
@@ -231,6 +231,8 @@ def db_engine_spec(self) -> Type[BaseEngineSpec]:
@property
def type_generic(self) -> Optional[utils.GenericDataType]:
column_spec = self.db_engine_spec.get_column_spec(self.type)
+ if self.is_dttm:
+ return GenericDataType.TEMPORAL
Review comment:
we can probably perform this check before `get_column_spec` on the row
above (I believe it's slightly more expensive than the if)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
