villebro opened a new pull request #14921:
URL: https://github.com/apache/superset/pull/14921


   ### SUMMARY
   Currently the filter box control panel shows legacy Druid specific controls 
even when legacy Druid isn't enabled. This PR removes the Druid specific 
sections if legacy Druid is not enabled, and also moves the controls to their 
own rows. In addition, a new property is added to `bootstrapData` to list 
installed optional Python dependencies to be able to customize control panels 
that depend on this functionality (in this case this will be used to show/hide 
the forecast section in the ECharts timeseries plugin).
   
   ### BEFORE
   Currently the SQL and Druid sections labels overlap each other:
   
![image](https://user-images.githubusercontent.com/33317356/120174869-43ef0280-c20e-11eb-97a3-b45f86419f27.png)
   
   ### AFTER
   With `DRUID_IS_ACTIVE` set to true:
   
![image](https://user-images.githubusercontent.com/33317356/120173954-400eb080-c20d-11eb-8c3e-14f44e9f9e5e.png)
   
   With `DRUID_IS_ACTIVE` set to false:
   
![image](https://user-images.githubusercontent.com/33317356/120174335-a4317480-c20d-11eb-9a30-da6b8e650471.png)
   
   
   ### TESTING INSTRUCTIONS
   <!--- Required! What steps can be taken to manually verify the changes? -->
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to