kgabryje commented on a change in pull request #14921:
URL: https://github.com/apache/superset/pull/14921#discussion_r642436385



##########
File path: superset-frontend/src/visualizations/FilterBox/controlPanel.jsx
##########
@@ -20,6 +20,37 @@ import React from 'react';
 import { t } from '@superset-ui/core';
 import { sections } from '@superset-ui/chart-controls';
 
+const appContainer = document.getElementById('app');
+const bootstrapData = JSON.parse(appContainer.getAttribute('data-bootstrap'));

Review comment:
       I think that we usually parse bootstrapped data in the main index file 
of a given view. Do you think we could move those 2 lines higher in the files 
hierarchy as well?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to