kgabryje commented on a change in pull request #14823:
URL: https://github.com/apache/superset/pull/14823#discussion_r642443565
##########
File path: superset-frontend/src/views/CRUD/welcome/ChartTable.tsx
##########
@@ -59,6 +61,9 @@ function ChartTable({
showThumbnails,
}: ChartTableProps) {
const history = useHistory();
+ const filterStore = getFromLocalStorage(HOMEPAGE_CHART_FILTER, null);
+ const defaultFilter = filterStore?.tab || 'Mine';
Review comment:
```suggestion
const defaultFilter = filterStore?.tab || TableTabTypes.MINE;
```
Can you replace other strings with constants/enums as well? There are a few
occurences of hardcoded strings like 'Favourite' or 'Mine'
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
